Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination options to list all package versions #2250

Conversation

lpsm-dev
Copy link
Contributor

@lpsm-dev lpsm-dev commented Jan 12, 2022

Here is the detail of the problem: #2251.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #2250 (7da192a) into master (6e66a89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2250   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         113      113           
  Lines       10207    10211    +4     
=======================================
+ Hits         9983     9987    +4     
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/users_packages.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e66a89...7da192a. Read the comment docs.

@gmlewis gmlewis changed the title feat: add options to work pagination on list all package versions Add pagination options to list all package versions Jan 12, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lpmatos !
Once you sign the CLA, we can move forward with this PR.
LGTM.

@gmlewis gmlewis requested a review from wesleimp January 12, 2022 03:46
@gmlewis gmlewis mentioned this pull request Jan 12, 2022
@lpsm-dev
Copy link
Contributor Author

lpsm-dev commented Jan 12, 2022

Thank you, @lpmatos ! Once you sign the CLA, we can move forward with this PR. LGTM.

@gmlewis Do I have to commit using my gmail? I followed all the steps mentioned in the documentation.

Sorry for the questions, this is my first contribution to a project like this.

@lpsm-dev lpsm-dev requested a review from gmlewis January 12, 2022 04:15
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 12, 2022

The CLA email needs to match the email address you associated with your GitHub commits, and it looks like you sorted it all out. Thanks.

We are now ready for a second LGTM/Approval from any other contributor to this repo.

Maybe @Parker77 has time to review this some time today.

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 12, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 002f016 into google:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants