Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GetCodeownersErrors to RepositoriesService (#2405) #2408

Merged
merged 6 commits into from
Jul 16, 2022
Merged

feat: add GetCodeownersErrors to RepositoriesService (#2405) #2408

merged 6 commits into from
Jul 16, 2022

Conversation

cbrgm
Copy link
Contributor

@cbrgm cbrgm commented Jul 8, 2022

This PR adds a new function GetCodeownersErrors to the RepositoriesService struct.
It adds support for the endpoint https://docs.github.com/en/rest/repos/repos#list-codeowners-errors as described in #2405

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #2408 (0d5cc3a) into master (fd22ee9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      120    +1     
  Lines       10546    10558   +12     
=======================================
+ Hits        10342    10354   +12     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/repos_codeowners.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd22ee9...0d5cc3a. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, @cbrgm - thank you!
Just a few minor tweaks, please, before we have a second reviewer approval.

github/repos_codeowners.go Show resolved Hide resolved
github/repos_codeowners.go Outdated Show resolved Hide resolved
github/repos_codeowners.go Show resolved Hide resolved
github/repos_codeowners_test.go Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 9, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cbrgm !
LGTM.

Awaiting LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 16, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 16, 2022

Thank you, @spikeb4 !
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants