-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SAML SSO authorization APIs #2835
Add support for SAML SSO authorization APIs #2835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joaopenteado !
Just a few tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2835 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 137 138 +1
Lines 12291 12314 +23
=======================================
+ Hits 12053 12076 +23
Misses 162 162
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joaopenteado !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thank you for the fast review and comments as always, @gmlewis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @joaopenteado ! Thank you very much!
I was wondering why the coverage dropped, but it looks like you found it and fixed it!
🎉
LGTM too :) |
Thank you, @o-sama ! |
This PR adds support for both
ListCredentialAuthorizations
andRemoveCredentialAuthorization
methods available for the GitHub Enterprise Cloud REST API for SAML SSO authorizations.