Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dependency Graph Snapshots endpoint #2856

Merged
merged 7 commits into from
May 5, 2024

Conversation

be0x74a
Copy link
Contributor

@be0x74a be0x74a commented Aug 5, 2023

Starts Dependency Graph service support by starting with the Create Snapshot endpoint

README.md Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
github/dependency_graph_snapshots.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (2b8c7fa) to head (fb0a8ef).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
- Coverage   97.72%   92.89%   -4.84%     
==========================================
  Files         153      171      +18     
  Lines       13390    11436    -1954     
==========================================
- Hits        13085    10623    -2462     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@be0x74a be0x74a requested a review from gmlewis August 19, 2023 14:09
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !

github/dependency_graph_snapshots.go Outdated Show resolved Hide resolved
github/dependency_graph_snapshots.go Show resolved Hide resolved
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 18, 2023

@be0x74a - we'll leave this PR open for a week or two, but if we haven't heard back from you, we will close this PR as abandoned.

@be0x74a be0x74a force-pushed the dependecy_graph_snapshots branch from 3ede035 to ef18b6c Compare April 28, 2024 22:30
@be0x74a be0x74a requested a review from gmlewis April 28, 2024 22:37
@be0x74a
Copy link
Contributor Author

be0x74a commented Apr 28, 2024

@be0x74a - we'll leave this PR open for a week or two, but if we haven't heard back from you, we will close this PR as abandoned.

@gmlewis finally got to it! Sorry for the delay and the force-push, was trying to appease codecov and make it use a recent base but I completely failed...

@google google deleted a comment from Al8900 Apr 29, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !
This looks much better. Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/dependency_graph_snapshots.go Outdated Show resolved Hide resolved
github/dependency_graph_snapshots.go Outdated Show resolved Hide resolved
github/dependency_graph_snapshots.go Outdated Show resolved Hide resolved
be0x74a and others added 2 commits April 29, 2024 22:03
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@be0x74a
Copy link
Contributor Author

be0x74a commented Apr 29, 2024

Thanks for the input @gmlewis!

@be0x74a be0x74a requested a review from gmlewis April 29, 2024 21:09
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. and removed waiting for reply labels Apr 29, 2024
Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 5, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented May 5, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis merged commit 807d5cf into google:master May 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants