Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role name to RepositoryPermissionLevel #3188

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

asultania-sc
Copy link
Contributor

@asultania-sc asultania-sc commented Jun 11, 2024

Fixes: #3189.

I am currently using this API to fetch what role does a user have on a repository. AFAICS, RepositoryPermissionLevel struct is missing role_name which is provided by the API (https://docs.github.com/en/rest/collaborators/collaborators?apiVersion=2022-11-28#get-repository-permissions-for-a-user). Due, to this I am unable to use the library. This PR introduces the field within the RepositoryPermissionLevel struct

Copy link

google-cla bot commented Jun 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 12, 2024

It looks like this might be a duplicate of #3186.

Please run step 4 found in CONTRIBUTING.md and push the auto-generated changes to this PR. Then, once the CLA is signed, we can merge.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (2b8c7fa) to head (007e8e8).
Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   97.72%   92.90%   -4.82%     
==========================================
  Files         153      171      +18     
  Lines       13390    11548    -1842     
==========================================
- Hits        13085    10729    -2356     
- Misses        215      726     +511     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @asultania-sc !
LGTM.
Merging.

@gmlewis gmlewis merged commit a2b2fc8 into google:master Jun 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RepositoryPermissionLevel is missing role_name
2 participants