Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add assignment for org role associations #3371

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

stevehipwell
Copy link
Contributor

Resolves #3364

This PR adds the Assignment field to Team & User and the InheritedFrom field to User when accessed in the context of an organization role.

@gmlewis gmlewis changed the title feat: Added assignment for org role associations feat: Add assignment for org role associations Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (1c73510).
Report is 185 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3371      +/-   ##
==========================================
- Coverage   97.72%   92.30%   -5.42%     
==========================================
  Files         153      176      +23     
  Lines       13390    15031    +1641     
==========================================
+ Hits        13085    13874     +789     
- Misses        215     1064     +849     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell !
LGTM.
Merging.

@gmlewis gmlewis merged commit 1616008 into google:master Dec 9, 2024
6 of 7 checks passed
@stevehipwell stevehipwell deleted the add-assignment branch December 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for assignment on teams and users assigned to organization roles
2 participants