Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add get for custom org repo role #3372

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

stevehipwell
Copy link
Contributor

Resolves #3370

This PR adds the missing GetCustomRepoRole function.

@gmlewis gmlewis changed the title feat: Added get for custom org repo role feat: Add get for custom org repo role Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (03073d5).
Report is 194 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3372      +/-   ##
==========================================
- Coverage   97.72%   92.30%   -5.42%     
==========================================
  Files         153      176      +23     
  Lines       13390    15044    +1654     
==========================================
+ Hits        13085    13887     +802     
- Misses        215     1064     +849     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehipwell stevehipwell force-pushed the add-get-org-repo-role branch from e10a8d7 to a5c855e Compare December 9, 2024 15:08
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

(Please use regular push (not force-push) in this repo because we always use "squash & merge" anyway and it is much easier for reviewers to see what has changed since the last look... thank you!)

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 9, 2024
@stevehipwell
Copy link
Contributor Author

RE force push, I'll try and do that next time but it's muscle memory at this point so apologies in advance. I think the desktop GH interface now shows diffs for force push events, but I'm currently on mobile so can't check.

@stevehipwell
Copy link
Contributor Author

@gmlewis I've rebased this PR, is there anything outstanding on it?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

@gmlewis I've rebased this PR, is there anything outstanding on it?

Only a second LGTM+Approval from any other contributor to this repo.
All contributors are volunteers so now we patiently wait for a second review. If you have coworkers who can review, please welcome their feedback. Thank you!

@stevehipwell
Copy link
Contributor Author

@gmlewis what is the requirement for the second approval? Someone who's already contributed or one of the maintainers or something else?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

@gmlewis what is the requirement for the second approval? Someone who's already contributed or one of the maintainers or something else?

We have never put any restrictions on this. Our official thoughts are detailed in CONTRIBUTING.md. In my personal opinion, we welcome contributions from anyone who is interested in the Go programming language.

@stevehipwell
Copy link
Contributor Author

@gmlewis my question above was about where the second set of eyes to approve a PR needs to come from? Do you need another maintainer or just another set of eyes from somewhere?

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

@gmlewis my question above was about where the second set of eyes to approve a PR needs to come from? Do you need another maintainer or just another set of eyes from somewhere?

I apologize that my answer was not clear, as I was attempting to answer this question.
The answer is the latter, preferably someone who is interested in the Go programming language.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

@stevehipwell - can you please make a concerted effort to stop force-pushing in this repo, as now I must re-read the whole PR because I cannot see what changed since the last review.

@stevehipwell
Copy link
Contributor Author

@gmlewis I'm just rebasing onto the min branch, my code isn't changing and GitHub shouldn't be clearing your approval. I can stop doing that, but you'll need to do it before the automation runs and the PR is merged to get a linear commit history (and in some cases GitHub can't do it in the UI).

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

@gmlewis I'm just rebasing onto the min branch, my code isn't changing and GitHub shouldn't be clearing your approval. I can stop doing that, but you'll need to do it before the automation runs and the PR is merged to get a linear commit history (and in some cases GitHub can't do it in the UI).

Actually, this isn't necessary because we always use "Squash and merge" in this repo, so the commit history is always clean.

Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 11, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 11, 2024
@gmlewis gmlewis merged commit 9505a7f into google:master Dec 11, 2024
6 of 7 checks passed
@stevehipwell stevehipwell deleted the add-get-org-repo-role branch December 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing function to get a custom repository role for an org
3 participants