chore: Deprecate legacy ID-based team methods

[stevehipwell]

Resolves #3368

This PR makes all legacy ID based team methods as deprecated based on the closing down notice.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (ff412f6).
Report is 190 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3373      +/-   ##
==========================================
- Coverage   97.72%   92.30%   -5.42%     
==========================================
  Files         153      176      +23     
  Lines       13390    15031    +1641     
==========================================
+ Hits        13085    13874     +789     
- Misses        215     1064     +849     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevehipwell]

@gmlewis the metadata generation doesn't look right. I manually updated all of the metadata (before I knew about the script) to fix the incorrect docs and URL templates for the legacy API calls but generate is putting them back.

Just a nit but is there a reason why //meta: isn't // meta:?

[gmlewis]

Just a nit but is there a reason why //meta: isn't // meta:?

Yes, that is an indication to the reader and the tools that this comment is used by the tooling.

[stevehipwell]

@gmlewis but what about the issue with linking to the incorrect docs?

https://github.com/google/go-github/blob/master/github/teams.go#L107...L112

[gmlewis]

@gmlewis but what about the issue with linking to the incorrect docs?

The links are managed by the official GitHub OpenAPI specification, and it periodically needs to be updated (which was last done here: #3352 ). I have not done a deep dive into this issue yet, but it may need updating again to fix the issue.

[gmlewis]

I've gone ahead and created #3374. I'm not sure if that will help your PR yet or not.

[gmlewis]

Once it is merged, you can update your local master branch with it, then merge master into this PR to see if it fixes the problems you are seeing.

[stevehipwell]

@gmlewis I don't think #3374 will help as the docs that should be linked are already present (search for -legacy at the bottom of the diff).

[gmlewis]

Thank you, @stevehipwell !
LGTM.
Merging.