Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(v2): csv - validate license URL and guess more if invalid #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Bobgy
Copy link
Collaborator

@Bobgy Bobgy commented Feb 27, 2022

Fixes #73

Assumption: the license URL we want to collect is always publically accessible
If there are concerns with this assumption, we can discuss several options:

  • hide the feature under a flag
  • enable validation by default, but provide a flag to disable this feature. Note we will be releasing v2, so we can consider making a breaking change if that's the default behavior we prefer.

@Bobgy Bobgy changed the title feat(v2): csv - validate license URL and guess more if invalid feat!(v2): csv - validate license URL and guess more if invalid Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve robustness of linking to license on hosting website
1 participant