Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: list dependencies from either import path or go binary #82

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

Bobgy
Copy link
Collaborator

@Bobgy Bobgy commented Sep 26, 2021

This PR is the same as #71.
I had to create a new PR, because I messed up with GitHub.

@google-cla google-cla bot added the cla: yes Contributor license agreement signed (https://cla.developers.google.com) label Sep 26, 2021
@Bobgy
Copy link
Collaborator Author

Bobgy commented Sep 29, 2021

The final conclusion for #71 was recorded in this comment.

Copy link
Contributor

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging this into master, but let's make the directory a little less official sounding - how about v2alpha1?

@Bobgy Bobgy changed the base branch from master to v2 September 29, 2021 22:59
@Bobgy
Copy link
Collaborator Author

Bobgy commented Sep 30, 2021

Thanks @wlynch for catching this! : )
I updated the branch to v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor license agreement signed (https://cla.developers.google.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants