Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): copy v1 code to v2 folder #93

Closed
wants to merge 1 commit into from
Closed

Conversation

Bobgy
Copy link
Collaborator

@Bobgy Bobgy commented Dec 31, 2021

Changes:

Copy link
Contributor

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question before I start reviewing these PRs in more details - are the changes to csv/check changes introducing any changes w.r.t input/outputs of the commands, or is this strictly an upgrade using module info?

If there isn't anything that would break compatibility with existing clients, it might make sense to just merge these into v1. 👀
The bits I was primarily concerned with the original v2 proposal were the new commands and the different output format.

@Bobgy
Copy link
Collaborator Author

Bobgy commented Jan 14, 2022

The PR is no longer necessary, because we decided to use the major branch approach for reaching v2.
#70 (comment)

@Bobgy Bobgy closed this Jan 14, 2022
@Bobgy Bobgy deleted the v2-v1 branch February 27, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants