Add configfs-tsm support for attestation reports #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongoshuu
approved these changes
Jan 16, 2024
| return append(report, certs...), nil | ||
| } | ||
|
|
||
| // GetRawQuote returns byte format attestation plus certificate table via /dev/sev-guest ioctl. |
There was a problem hiding this comment.
Shall we add a log that this interface is getting deprecated?
There was a problem hiding this comment.
No, the deprecation notice will be in the release notes.
Given Dan Williams's configfs-tsm patch set to the Linux kernel, all attestation reports ought to be requested through configfs and not ioctls. This marks the deprecation of the Device interface for reports, but not for keys. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Dan Williams's configfs-tsm patch set to the Linux kernel, all attestation reports ought to be requested through configfs and not ioctls.
This marks the deprecation of the Device interface for reports, but not for keys.
Tested locally with go-tpm-tools. Should be an easy update.