Added check for tika jar file, updated accompanying test #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbpg
requested changes
Mar 25, 2020
Comment on lines
+116
to
+119
| s.jar = "nonexistentFile.jar" | ||
| if err := s.Start(ctx); err == nil { | ||
| t.Fatalf("s.Start got no error, want error for missing Jar file") | ||
| } |
There was a problem hiding this comment.
Please add this to TestStartError (which may need to be updated to point to real files).
There was a problem hiding this comment.
This is in TestStartError. I am unsure of what your are asking.
tika/server.go
Outdated
| if _, err := os.Stat(s.jar); os.IsNotExist(err) { | ||
| return err | ||
| } | ||
| cmd := command("java", append([]string{"-jar", s.jar, "-p", s.port}, s.child.args()...)...) |
There was a problem hiding this comment.
woops. Repushed.
Comment on lines
+131
to
+133
| if _, err := os.Stat(s.jar); os.IsNotExist(err) { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Should we do this in NewServer? Could see doing it in either function.
There was a problem hiding this comment.
I agree, could be in either. Pathing of where things are called from could come into play, which is why I put it here and not in NewServer.
bitcoin-coder-bob
changed the title
Added an additional line by accident. Removed it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this issue: #17
Fixes the silent missing jar file error. Added accompanying test.