Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server go.doc #35

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Update server go.doc #35

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faca0fc
Update server go.doc
nathj07 Mar 31, 2022
08dac0f
responding to feedback
nathj07 Apr 1, 2022
bccb2d7
Merge branch 'main' into update-go-doc-download-example
nathj07 Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
*.jar

# editor files
*.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*.idea
*.idea

11 changes: 7 additions & 4 deletions tika/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,22 @@ Start with basic imports:
import "github.com/google/go-tika/tika"

You will need a running Server to make API calls to. So, if you don't
have a server that is already running and you don't have the Server
have a server that is already running, and you don't have the Server
JAR already downloaded, you can download one. The caller is responsible
for removing the file when no longer needed.
for removing the file when no longer needed. Version is a custom type,
and should be passed as such. There are constants in the code for these.
The following example downloads version 1.21 to the named JAR in the
current working directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for removing the file when no longer needed. Version is a custom type,
and should be passed as such. There are constants in the code for these.
The following example downloads version 1.21 to the named JAR in the
current working directory.
for removing the file when no longer needed.
Version is a custom type,
and should be passed as such. There are constants in the code for these.
The following example downloads version 1.21 to the named JAR in the
current working directory.

(New paragraph, need to adjust line breaks.)


err := tika.DownloadServer(context.Background(), "1.16", "tika-server-1.16.jar")
err := tika.DownloadServer(context.Background(), tika.Version121, "tika-server-1.21.jar")
if err != nil {
log.Fatal(err)
}

If you don't have a running Tika Server, you can start one.

// Optionally pass a port as the second argument.
s, err := tika.NewServer("tika-server-1.16.jar", "")
s, err := tika.NewServer("tika-server-1.21.jar", "")
if err != nil {
log.Fatal(err)
}
Expand Down