-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Canonical Event Log(CEL) operations #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkl73
force-pushed
the
cel
branch
4 times, most recently
from
November 3, 2021 20:18
61db5fe
to
f04664f
Compare
alexmwu
reviewed
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Mostly nits, core logic is looking good.
jkl73
force-pushed
the
cel
branch
4 times, most recently
from
November 16, 2021 05:46
3e88ce7
to
efba2d5
Compare
Moved the CEL files out of the client package, created a new package named cel. |
alexmwu
approved these changes
Nov 18, 2021
jkl73
force-pushed
the
cel
branch
2 times, most recently
from
November 19, 2021 03:33
3a92951
to
0ba66e9
Compare
josephlr
reviewed
Dec 2, 2021
josephlr
reviewed
Dec 2, 2021
josephlr
reviewed
Dec 2, 2021
Defined CEL TLV struct, added encoding/decoding functions
josephlr
reviewed
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined CEL TLV struct, added encoding/decoding functions