Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Canonical Event Log(CEL) operations #140

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

jkl73
Copy link
Contributor

@jkl73 jkl73 commented Nov 2, 2021

Defined CEL TLV struct, added encoding/decoding functions

@jkl73 jkl73 force-pushed the cel branch 4 times, most recently from 61db5fe to f04664f Compare November 3, 2021 20:18
@jkl73 jkl73 requested review from alexmwu and josephlr November 3, 2021 20:20
Copy link
Contributor

@alexmwu alexmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Mostly nits, core logic is looking good.

client/costlv.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
client/canonical_eventlog.go Outdated Show resolved Hide resolved
@jkl73 jkl73 force-pushed the cel branch 4 times, most recently from 3e88ce7 to efba2d5 Compare November 16, 2021 05:46
@jkl73
Copy link
Contributor Author

jkl73 commented Nov 16, 2021

Moved the CEL files out of the client package, created a new package named cel.

@jkl73 jkl73 force-pushed the cel branch 2 times, most recently from 3a92951 to 0ba66e9 Compare November 19, 2021 03:33
cel/canonical_eventlog.go Outdated Show resolved Hide resolved
cel/canonical_eventlog.go Outdated Show resolved Hide resolved
cel/cos_tlv.go Outdated Show resolved Hide resolved
cel/cos_tlv.go Outdated Show resolved Hide resolved
cel/cos_tlv.go Outdated Show resolved Hide resolved
Defined CEL TLV struct, added encoding/decoding functions
@josephlr josephlr merged commit 3cf7e5e into google:master Dec 2, 2021
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants