cel: Some ideas for ergonomics improvements #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the Record structure easier to use by just creating the TLV fields in the EncodeCELR function. Signed-off-by: Joe Richey <joerichey@google.com>
There is no longer a reason for these fields to be public (as they are only used in DecodeToCELR. Signed-off-by: Joe Richey <joerichey@google.com>
alexmwu
approved these changes
Dec 3, 2021
| @@ -35,7 +35,7 @@ type TLV struct { | |||
| } | |||
|
|
|||
| // MarshalBinary marshals a TLV to a byte slice. | |||
| func (tlv *TLV) MarshalBinary() (data []byte, err error) { | |||
| func (tlv TLV) MarshalBinary() (data []byte, err error) { | |||
There was a problem hiding this comment.
typically they are pointer receivers: https://cs.opensource.google/search?q=MarshalBinary()&ss=go%2Fgo:src%2F&start=1
There was a problem hiding this comment.
So it seems like:
- the digest types all use pointer receivers
time.Timeuses a value receiverip.Addr/ip.AddrPort/ip.Prefixuse a value receiver- Some of the
gobadapters use pointer receivers json.RawMessageuses value receivers for marshaling and pointer receivers for unmarshaling.
So I think it's fine to use a value receiver here. The type is small, marshaling doesn't change the value, and if I change it to a pointer receiver the code doesn't compile.
This is because you then can't do something like:
createRecNumField(r.RecNum).MarshalBinary()as temporary values do not have an address.
jkl73
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ideas about how we might make CEL stuff easier to work with.
@alexmwu @jkl73 what do you think? Worth doing?