Introduce shim verifier client to the launcher #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkl73
approved these changes
May 31, 2022
The shim client will serve as a common abstraction between different attestation verifier implementations. For now, we just wrap the gRPC attestation verifier in the client. Eventually, with other attestation verifiers, we can support multiple protocols more easily as well as create a more robust fake.
There are already multiple files named attest.go, causing confusion. Since launcher/attest.go contains the attestation agent, agent.go is a better name.
Also fix minor lint nits.
josephlr
approved these changes
Jun 1, 2022
Export Challenge and VerifyAttestationResponse fields, except for Challenge.connID. Fix minor formatting issue. Remove logger from verifier.Client in favor of attestation verifier specific logging.
Sure, I moved it into internal/verifier and also regenerated the pbs/upgraded the protobuf lib |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shim client will serve as a common abstraction between different attestation verifier implementations. For now, we just wrap the gRPC attestation verifier in the client. Eventually, with other attestation verifiers, we can support multiple protocols more easily as well as create a more robust fake.
This PR also renames
launcher/attest.gotolauncher/agent.go