Improve rest.NewClient error handling. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now get better error messages. For example: No credentials: ``` Getting HTTP Client: google: could not find default credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information. ``` Credentials, but invalid project: ``` Creating Verifier Client: listing regions in project "confidentialcomputing-e2eee": googleapi: Error 403: Permission denied on resource project confidentialcomputing-e2eee. Details: [ { "@type": "type.googleapis.com/google.rpc.Help", "links": [ { "description": "Google developer console API key", "url": "https://console.developers.google.com/project/confidentialcomputing-e2eee/apiui/credential" } ] }, { "@type": "type.googleapis.com/google.rpc.ErrorInfo", "domain": "googleapis.com", "metadata": { "consumer": "projects/confidentialcomputing-e2eee", "service": "confidentialcomputing.googleapis.com" }, "reason": "CONSUMER_INVALID" } ] , forbidden ``` Credentials, valid project, invalid region: ``` Creating Verifier Client: invalid region "us-central3", avaiable regions are [us-central1]: googleapi: Error 403: Location us-central3 is not found or access is unauthorized., forbidden ``` Creaentials with valid project/region passes: ``` Got Token: |eyJhbGciOiJSUzI1NiIsImtpZCI6IjluRmdNWWVCZ1A2U1N4V19kZGpiQndJSFB2WEVNTGdZQVh2dU1iS1JrV0EiLCJ0eXAiOiJKV1QifQ.eyJhdWQiOiJodHRwczovL3N0cy5nb29nbGVhcGlzLmNvbSIsImV4cCI6MTY1NzE0NjE0NSwiaWF0IjoxNjU3MTM4OTQ1LCJpc3MiOiJodHRwczovL2NvbmZpZGVudGlhbGNvbXB1dGluZy5nb29nbGVhcGlzLmNvbSIsIm5iZiI6MTY1NzEzODk0NSwic3ViIjoiaHR0cHM6Ly93d3cuZ29vZ2xlYXBpcy5jb20vY29tcHV0ZS92MS9wcm9qZWN0cy9iaXRsb2NrZXItZGFuY2UtZGVtby96b25lcy91cy13ZXN0Mi1jL2luc3RhbmNlcy91YnUyMCIsInRlZSI6eyJ2ZXJzaW9uIjp7Im1ham9yIjowLCJtaW5vciI6MX0sInBsYXRmb3JtIjp7ImhhcmR3YXJlX3RlY2hub2xvZ3kiOiJBTURfU0VWIn0sImNvbnRhaW5lciI6eyJpbWFnZV9yZWZlcmVuY2UiOiJsYXVuY2hlci5nY3IuaW8vZ29vZ2xlL2RlYmlhbjEwOmxhdGVzdCIsImltYWdlX2RpZ2VzdCI6InNoYTI1NjpmZjE2NGE2NzY2YmQ4YmQyZDdkNWU5NGRiNDE4NjQ2NDI2ZTU4NzJjNjY0YzZhMjcwYzY4OWYwYjFkMjhmODZmIiwicmVzdGFydF9wb2xpY3kiOiJOZXZlciIsImltYWdlX2lkIjoic2hhMjU2OjMwZTM4MDUyNDJlNTAyMjMyM2E5N2Y4YjZkZWVjODRmZTU4MzIwYzNjYzFlNzE3NDI5ZGY3ZjQ3YjViMzE3YmUiLCJlbnYiOnsiRk9PIjoiQkFSIiwiUEFUSCI6Ii91c3IvbG9jYWwvc2JpbjovdXNyL2xvY2FsL2JpbjovdXNyL2JpbiIsIlNPTUVfTkFNRSI6IlNPTUVfVkFMVUUifSwiYXJncyI6WyItLWZvbyIsImJhciIsImJheiJdfSwiZ2NlIjp7InpvbmUiOiJ1cy13ZXN0Mi1jIiwicHJvamVjdF9pZCI6ImJpdGxvY2tlci1kYW5jZS1kZW1vIiwicHJvamVjdF9udW1iZXIiOjU2NzA0NTA1Mzg3OCwiaW5zdGFuY2VfbmFtZSI6InVidTIwIiwiaW5zdGFuY2VfaWQiOiIyOTk0MDE1NTM3NjgyNTU0NzA5In0sImVtYWlscyI6WyJjeWhhbmlzaEBnb29nbGUuY29tIiwiamVzc2llcWxpdUBnb29nbGUuY29tIl19fQ.EpDSQqR5E9rS6FWsX2CeS2HVfvcITG3vScpyNPV7OSLR7uBFVh6RZTPqOOu5qPRT_Wox2jxRwDTAa8uqQyCwPAJnpJbMSXSD4qkOK72osYVfW-h6nanAsM8pFOYY4xyW9jhqegIopken6yBmhxzvH9sMsslDRbNXRN1OQZ0rhp0Sb3uJNfXRx52ewJepuNSaq-uV4SbqphwnkqkrxgewmgdNYlNFeHhP2krZXqfyWpjeFkQzQzcZf-epoIGAC-DSoPGLZKvXyyDz1vufW7SdB5pmOK0eEADCzeTPyaSN-RJm1hKaWL2YmkvsLwdOaLPystIGqsy8oScZVffB1Z5ESQ| ``` Signed-off-by: Joe Richey <joerichey@google.com>
jkl73
approved these changes
Jul 8, 2022
alexmwu
approved these changes
Jul 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now get better error messages. For example:
No credentials:
Credentials, but invalid project:
Credentials, valid project, invalid region:
Credentials with valid project/region passes:
Signed-off-by: Joe Richey joerichey@google.com