Update ContainerRunner to use REST verifier #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmwu
force-pushed
the
restLauncher
branch
2 times, most recently
from
390dad5 to
e90bf9b
Compare
josephlr
approved these changes
Jul 12, 2022
We update the LauncherSpec to store the projectID and region. The ContainerRunner will now be able to use the REST-based verifier.Client, based on the addr flag. The flag will determine whether the endpoint is the gRPC or REST verifier. The REST verifier is used if the flag is empty or contains "http", otherwise the gRPC verifier is used.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update the LauncherSpec to store the projectID and region.
The ContainerRunner will now be able to use the REST-based verifier.Client, based on the addr flag.
The flag will determine whether the endpoint is the gRPC or REST verifier. The REST verifier is used if the flag is empty or contains "http", otherwise the gRPC verifier is used.