Allow loading of cached keys #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alexmwu
reviewed
May 31, 2023
alexmwu
reviewed
Jun 21, 2023
alexmwu
approved these changes
Jun 21, 2023
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Jun 23, 2023
New Features: [launcher] Add capability to open ports google#294 Allow loading of cached keys google#313 Other Changes: Use legacy tpm2 at its new path google#318 Add GoReleaser release action for gotpm CLI google#319 Update go-tpm dependency to 0.9.0 google#321
Merged
alexmwu
added a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #237.
As discussed in the issue, I exposed the different sessions to be able to set it in the loaded key.
If you don't want to expose all possible sessions, exposing just the
NullSessionis sufficient for our use-case.