Decrease MaxElapsedTime for retry backoff in tests #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmwu
approved these changes
Jul 18, 2023
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Jul 27, 2023
This reverts commit 4a3d6e7. This commit has made our CI flakey, and we do not need to enable this test internally in g3.
alexmwu
added a commit
that referenced
this pull request
Jul 27, 2023
yawangwang
added a commit
to yawangwang/go-tpm-tools
that referenced
this pull request
Aug 16, 2023
Revert "Decrease MaxElapsedTime for retry backoff in tests (google#337)" (google#341) This reverts commit 4a3d6e7. This commit has made our CI flakey, and we do not need to enable this test internally in g3. [Signature discovery] Add a signature interface and a library to parse signature from image manifest (google#328) * Adding a signature interface and its implementations to parse cosign-generated signatures from OCI image object Integrate signature discovery client into attestation agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The g3 import of the backoff library (v1.1.1) handles exponential backoff a little differently, so the current container_runner tests fail in g3 . Decreasing MaxElapsedTime in the test backoff fixes this.