Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[launcher] Increase the max file descriptor #339

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

jkl73
Copy link
Contributor

@jkl73 jkl73 commented Jul 19, 2023

Increase the max file descriptor (nofile) for the container process from 1024 to 131072.

Check the container process limit, can see the updated number (Max open files):

OLD

$ cat /proc/1102/limits 
Limit                     Soft Limit           Hard Limit           Units     
Max cpu time              unlimited            unlimited            seconds   
Max file size             unlimited            unlimited            bytes     
Max data size             unlimited            unlimited            bytes     
Max stack size            8388608              unlimited            bytes     
Max core file size        unlimited            unlimited            bytes     
Max resident set          unlimited            unlimited            bytes     
Max processes             unlimited            unlimited            processes 
Max open files            1024                 1024                 files     
Max locked memory         8388608              8388608              bytes     
Max address space         unlimited            unlimited            bytes     
Max file locks            unlimited            unlimited            locks     
Max pending signals       29964                29964                signals   
Max msgqueue size         819200               819200               bytes     
Max nice priority         0                    0                    
Max realtime priority     0                    0                    
Max realtime timeout      unlimited            unlimited            us     

NEW

$ cat /proc/1115/limits 
Limit                     Soft Limit           Hard Limit           Units     
Max cpu time              unlimited            unlimited            seconds   
Max file size             unlimited            unlimited            bytes     
Max data size             unlimited            unlimited            bytes     
Max stack size            8388608              unlimited            bytes     
Max core file size        unlimited            unlimited            bytes     
Max resident set          unlimited            unlimited            bytes     
Max processes             unlimited            unlimited            processes 
Max open files            131072               131072               files     
Max locked memory         8388608              8388608              bytes     
Max address space         unlimited            unlimited            bytes     
Max file locks            unlimited            unlimited            locks     
Max pending signals       29964                29964                signals   
Max msgqueue size         819200               819200               bytes     
Max nice priority         0                    0                    
Max realtime priority     0                    0                    
Max realtime timeout      unlimited            unlimited            us   

@jkl73 jkl73 requested a review from alexmwu July 19, 2023 21:08
@alexmwu
Copy link
Contributor

alexmwu commented Jul 20, 2023

can you print the limits for a regular process to compare with?

launcher/container_runner.go Outdated Show resolved Hide resolved
Increase the max file descriptor (nofile) for the container
process from 1024 to 131072.
@jkl73 jkl73 merged commit 710e41a into google:master Jul 20, 2023
alexmwu added a commit to alexmwu/go-tpm-tools that referenced this pull request Sep 15, 2023
New Features:
[launcher] Verify FS and mount before launch google#311
Integration of go-tpm-tools with go-tdx-guest google#347

Intra-version Breaking Changes:
Add launcherfile package for path and file consts google#356 breaks google#333
Bug Fixes:
[launcher] Update the token refresh logic google#325
[launcher] Fix logging blocking issue google#338

Other Changes:
[launcher] Add a new metadata flag of signedImageRepos google#320
Update go-sev-guest to v0.7.0 google#329
[launcher] Add SSH test for image. google#314
Add supported architectures to ci.yml google#330
Fix the go version number error google#326
[launcher] Signature discovery: fetch a signed image manifest at for parsing google#324
[launcher] Export attestation token filepath and filename google#333
[launcher] Increase the max file descriptor google#339
[launcher] Add a signature interface and a library to parse signature from image manifest google#328
Rename TdxVerify function to TdxQuote in server package. google#353
[launcher] Use V1 SDK in launcher verifier client google#305
Update and tidy dependencies google#344
@alexmwu alexmwu mentioned this pull request Sep 15, 2023
alexmwu added a commit that referenced this pull request Sep 15, 2023
New Features:
[launcher] Verify FS and mount before launch #311
Integration of go-tpm-tools with go-tdx-guest #347

Intra-version Breaking Changes:
Add launcherfile package for path and file consts #356 breaks #333
Bug Fixes:
[launcher] Update the token refresh logic #325
[launcher] Fix logging blocking issue #338

Other Changes:
[launcher] Add a new metadata flag of signedImageRepos #320
Update go-sev-guest to v0.7.0 #329
[launcher] Add SSH test for image. #314
Add supported architectures to ci.yml #330
Fix the go version number error #326
[launcher] Signature discovery: fetch a signed image manifest at for parsing #324
[launcher] Export attestation token filepath and filename #333
[launcher] Increase the max file descriptor #339
[launcher] Add a signature interface and a library to parse signature from image manifest #328
Rename TdxVerify function to TdxQuote in server package. #353
[launcher] Use V1 SDK in launcher verifier client #305
Update and tidy dependencies #344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants