Container launcher prints signature details instead of signature object #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawangwang
force-pushed
the
print-signature-details
branch
3 times, most recently
from
a42c20c to
8683300
Compare
alexmwu
requested changes
Oct 13, 2023
| @@ -68,3 +70,12 @@ func (s Sig) PublicKey() ([]byte, error) { | |||
| func (s Sig) SigningAlgorithm() (oci.SigningAlgorithm, error) { | |||
| return "", fmt.Errorf("not implemented") | |||
| } | |||
|
|
|||
| // String returns signature details | |||
| func (s Sig) String() string { | |||
yawangwang
force-pushed
the
print-signature-details
branch
from
8683300 to
a956ebc
Compare
alexmwu
approved these changes
Oct 13, 2023
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Oct 27, 2023
New Features: [launcher] Add experiment support google#352 [launcher] Integrate signature discovery client into attestation agent google#343 Bug Fixes: Make launcher host tmp directory before experiment fetch google#363 Other Changes: [launcher] Print kernel cmdline on builds google#268 Import latest version of go-tdx-guest google#373 [launcher] Print signature details instead of signature object google#374 [launcher] Add image tests for the experiments binary google#378 Update go-sev-guest to v0.9.3 google#381
Merged
alexmwu
added a commit
that referenced
this pull request
Oct 27, 2023
New Features: [launcher] Add experiment support #352 [launcher] Integrate signature discovery client into attestation agent #343 Bug Fixes: Make launcher host tmp directory before experiment fetch #363 Other Changes: [launcher] Print kernel cmdline on builds #268 Import latest version of go-tdx-guest #373 [launcher] Print signature details instead of signature object #374 [launcher] Add image tests for the experiments binary #378 Update go-sev-guest to v0.9.3 #381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/google/go-tpm-tools/blob/main/launcher/agent/agent.go#L105 https://screenshot.googleplex.com/7wxmTBPQubwZLoB, the launcher prints golang objects for any found signatures, we should print signature details instead.