Add eventlog parse logics for memory monitoring #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawangwang
force-pushed
the
measure-monitor
branch
2 times, most recently
from
860a4aa
to
f812084
Compare
yawangwang
changed the title
yawangwang
force-pushed
the
measure-monitor
branch
from
f812084
to
74565d7
Compare
|
/gcbrun |
|
We can split the change to 2 PRs, we first merge the eventlog parsing logic, and wait for it to deploy to the service. And then merge the measuring logic PR, so the image test can pass here. |
yawangwang
force-pushed
the
measure-monitor
branch
from
74565d7
to
c5cf363
Compare
|
/gcbrun |
Looks like confidential space VMs failed to start due to unknown COS event type errors returned by |
yawangwang
force-pushed
the
measure-monitor
branch
from
c5cf363
to
0ef9cd5
Compare
|
/gcbrun |
yawangwang
changed the title
yawangwang
force-pushed
the
measure-monitor
branch
from
0ef9cd5
to
f5182a2
Compare
|
/gcbrun |
jkl73
reviewed
Jan 11, 2024
server/eventlog.go
Outdated
| @@ -198,6 +199,10 @@ func getVerifiedCosState(coscel cel.CEL) (*pb.AttestedCosState, error) { | |||
| cosState.Container.OverriddenEnvVars[envName] = envVal | |||
| case cel.LaunchSeparatorType: | |||
| seenSeparator = true | |||
| case cel.MemoryMonitorType: | |||
| if len(cosTlv.EventContent) > 0 && cosTlv.EventContent[0] == uint8(1) { | |||
There was a problem hiding this comment.
Can be more definitive here, by making sure the len(cosTlv.EventContent) == 1
There was a problem hiding this comment.
And for failsafe, I think the default value for cosState.HealthMonitoring.MemoryEnabled should be true, and when we see the eventContent == 0 here, we can turn it to false
There was a problem hiding this comment.
Can be more definitive here, by making sure the len(cosTlv.EventContent) == 1
Done.
There was a problem hiding this comment.
And for failsafe, I think the default value for cosState.HealthMonitoring.MemoryEnabled should be true, and when we see the eventContent == 0 here, we can turn it to false
Discussed offline, we agree to keep the default value as false.
yawangwang
force-pushed
the
measure-monitor
branch
from
f5182a2
to
ae94175
Compare
|
/gcbrun |
jkl73
approved these changes
Jan 11, 2024
yawangwang
force-pushed
the
measure-monitor
branch
from
ae94175
to
6bf9b59
Compare
|
/gcbrun |
yawangwang
force-pushed
the
measure-monitor
branch
from
6bf9b59
to
4a1e981
Compare
|
/gcbrun |
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Feb 22, 2024
New Features: [launcher] Add TEE server IPC implementation google#367 [launcher] Enable memory monitoring in CS google#391 Use TDX quote provider to attest and verify google#405 Integrate nonce verification as part of the TDX quote validation procedure. google#395 Add RISC V support google#407 [launcher] Use resizable integrity-fs with in-memory tags google#412 Bug Fixes: [launcher] Fix launcher exit code google#384 [launcher] Handle exit code checking during deferral evaluation google#392 [cmd] Skip tests that call setGCEAKTemplate google#402 [launcher] Fix teeserver context reset issue & add container signature cache google#397 Set all unused parameters as _ to fix CI lint failure google#411 [launcher] Make customtoken test sleep to mitigate clock skew google#413 Other Changes: Add eventlog parse logics for memory monitoring google#404 [launcher]: Add memory monitor measurement logics google#408 Update go-tdx-guest version to v0.3.1 google#414 New Contributors: @KeithMoyer in google#392 @vbalain in google#405 @aimixsaka in google#407
Merged
alexmwu
added a commit
that referenced
this pull request
Feb 22, 2024
New Features: [launcher] Add TEE server IPC implementation #367 [launcher] Enable memory monitoring in CS #391 Use TDX quote provider to attest and verify #405 Integrate nonce verification as part of the TDX quote validation procedure. #395 Add RISC V support #407 [launcher] Use resizable integrity-fs with in-memory tags #412 Bug Fixes: [launcher] Fix launcher exit code #384 [launcher] Handle exit code checking during deferral evaluation #392 [cmd] Skip tests that call setGCEAKTemplate #402 [launcher] Fix teeserver context reset issue & add container signature cache #397 Set all unused parameters as _ to fix CI lint failure #411 [launcher] Make customtoken test sleep to mitigate clock skew #413 Other Changes: Add eventlog parse logics for memory monitoring #404 [launcher]: Add memory monitor measurement logics #408 Update go-tdx-guest version to v0.3.1 #414 New Contributors: @KeithMoyer in #392 @vbalain in #405 @aimixsaka in #407
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 29, 2024
New Features: [launcher] Add TEE server IPC implementation google#367 [launcher] Enable memory monitoring in CS google#391 Use TDX quote provider to attest and verify google#405 Integrate nonce verification as part of the TDX quote validation procedure. google#395 Add RISC V support google#407 [launcher] Use resizable integrity-fs with in-memory tags google#412 Bug Fixes: [launcher] Fix launcher exit code google#384 [launcher] Handle exit code checking during deferral evaluation google#392 [cmd] Skip tests that call setGCEAKTemplate google#402 [launcher] Fix teeserver context reset issue & add container signature cache google#397 Set all unused parameters as _ to fix CI lint failure google#411 [launcher] Make customtoken test sleep to mitigate clock skew google#413 Other Changes: Add eventlog parse logics for memory monitoring google#404 [launcher]: Add memory monitor measurement logics google#408 Update go-tdx-guest version to v0.3.1 google#414 New Contributors: @KeithMoyer in google#392 @vbalain in google#405 @aimixsaka in google#407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding eventlog parse logics for memory monitoring.