add cloud log flag: add records to cloud logging when fetching token from attestation verifier #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
alexmwu
reviewed
Feb 27, 2024
|
/gcbrun |
alexmwu
reviewed
Feb 27, 2024
Ruide
force-pushed
the
cloud-logging
branch
3 times, most recently
from
5c46471 to
51895c1
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Ruide
force-pushed
the
cloud-logging
branch
2 times, most recently
from
4f37af4 to
2fa358c
Compare
|
/gcbrun |
alexmwu
reviewed
Mar 4, 2024
|
/gcbrun |
|
/gcbrun |
alexmwu
approved these changes
Mar 6, 2024
| var cloudLogger *logging.Logger | ||
| if cloudLog { | ||
| if audience == "" { | ||
| return errors.New("cloud logging requires the --audience flag") |
There was a problem hiding this comment.
capitalize Cloud Logging, as it's a proper noun
There was a problem hiding this comment.
go-staticcheck would give "error strings should not be capitalized (ST1005)"
| @@ -72,7 +72,12 @@ func TestTokenWithGCEAK(t *testing.T) { | |||
| } | |||
| defer mockAttestationServer.Stop() | |||
|
|
|||
| RootCmd.SetArgs([]string{"token", "--algo", op.algo, "--output", secretFile1, "--asAddr", mockAttestationServer.server.URL}) | |||
| mockCloudLoggingServerAddress, err = newMockCloudLoggingServer() | |||
There was a problem hiding this comment.
I would have expected you to check the loggingHandler.logs output matches up.
There was a problem hiding this comment.
The attestation would give different ak_cert since we are using tpm simulator. Do you have a reference or recommendation on a deterministic TPM simulator output?
There was a problem hiding this comment.
I create a new PR with the loggingHandler.logs output matches up. I use a simple field comparison for attestation. Please let me know if there is a better way!
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 29, 2024
Breaking Changes: [launcher/cmd] Refactor verifier for issue google#419 * Unexport `cmd.Instance`, `cmd.MetadataServer`, `cmd.NewMetadataServer`. * Move package `verifier` from launcher to go-tpm-tools. * `verifier.Client`, `verifier.Challenge`, etc. * Move package `fake` from launcher to go-tpm-tools. * `fake.Claims`, `fake.NewClient`, etc. * Move package `rest` from launcher to go-tpm-tools. * `rest.NewClient`, `rest.BadRegionError`, etc. New Features: [cmd] Add new command token in the CLI tool google#375 [cmd] add records to cloud logging when fetching token from attestation verifier google#417 Bug Fixes: Statically link binaries built by goreleaser google#425 Other Changes: Update readme to include the instruction to use the prebuilt gotpm tool. google#424 New Contributors: @Ruide in google#375 @qinkunbao in google#424
Merged
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 29, 2024
Breaking Changes: [launcher/cmd] Refactor verifier for issue google#419 * Unexport `cmd.Instance`, `cmd.MetadataServer`, `cmd.NewMetadataServer`. * Move package `verifier` from launcher to go-tpm-tools. * `verifier.Client`, `verifier.Challenge`, etc. * Move package `fake` from launcher to go-tpm-tools. * `fake.Claims`, `fake.NewClient`, etc. * Move package `rest` from launcher to go-tpm-tools. * `rest.NewClient`, `rest.BadRegionError`, etc. New Features: [cmd] Add new command token in the CLI tool google#375 [cmd] add records to cloud logging when fetching token from attestation verifier google#417 Bug Fixes: Statically link binaries built by goreleaser google#425 Other Changes: Update readme to gotpm CLi instructions. google#424, google#426 New Contributors: @Ruide in google#375 @qinkunbao in google#424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.