Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod dependencies #225

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Update go.mod dependencies #225

merged 1 commit into from
Dec 9, 2020

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Dec 8, 2020

For some reason this added 151 lines to go.sum, but I don't think that's a big deal

Signed-off-by: Joe Richey joerichey@google.com

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr requested review from ChriMarMe, twitchy-jsonp, BenDHillier and jkl73 and removed request for ChriMarMe December 8, 2020 20:46
@ChriMarMe
Copy link
Collaborator

Did you do?

go mod tidy

@josephlr
Copy link
Member Author

josephlr commented Dec 9, 2020

Did you do?

go mod tidy

Yes I did, it didn't change anything

EDIT: Deleting go.sum and running go mod tidy also didn't change anything. Maybe I just shouldn't expect go.sum to look reasonable.

@ChriMarMe
Copy link
Collaborator

ChriMarMe commented Dec 9, 2020

I tried that too. go.sum --> 💩

EDIT: I will make a guess: in go.sum we will see all dependencies, and with all, I mean all....dependencies of dependencies of dependencies.

@josephlr
Copy link
Member Author

josephlr commented Dec 9, 2020

I tried that too. go.sum -->

Ya, it looks like go.sum will always just have a lot of lines (basically every version of every transitive dep ever used). This sucks, but it seems to be the way things are.

@ChriMarMe
Copy link
Collaborator

go mod is just a behemoth 🤷

@ChriMarMe
Copy link
Collaborator

From Go Modules Reference

A module may have a text file named go.sum in its root directory, alongside its go.mod file. The go.sum file contains cryptographic hashes of the module's direct and indirect dependencies. When the go command downloads a module .mod or .zip file into the module cache, it computes a hash and checks that the hash matches the corresponding hash in the main module's go.sum file. go.sum may be empty or absent if the module has no dependencies or if all dependencies are replaced with local directories using replace directives.

@josephlr josephlr requested review from chrisfenner and removed request for BenDHillier and jkl73 December 9, 2020 20:56
@josephlr
Copy link
Member Author

josephlr commented Dec 9, 2020

@chrisfenner or @twitchy-jsonp it looks like I need a CODEOWNERS approval to merge this.

@twitchy-jsonp twitchy-jsonp merged commit 12da4a5 into google:master Dec 9, 2020
@josephlr josephlr deleted the deps branch December 9, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants