quote: Remove internal usage of ownerPassword with Quote #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmwu
reviewed
Jun 10, 2021
alexmwu
approved these changes
Jun 10, 2021
alexmwu
reviewed
Jun 10, 2021
Quote only takes one authorization area, so our functions shouldn't take two passwords. To avoid a breaking change, the function signature of `Quote` and `QuoteRaw` are note changed, but `encodeQuote` drops the parameter. We should remove the superflous param from the public functions when we next make a breaking change. Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
"signerAuth" is more consistent with Certify(). Also add TODO to Quote (as well as QuoteRaw). Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote only takes one authorization area, so our functions shouldn't take
two passwords. To avoid a breaking change, the function signature of
QuoteandQuoteRaware note changed, butencodeQuotedrops theparameter.
We should remove the superflous param from the public functions when we
next make a breaking change.
Signed-off-by: Joe Richey joerichey@google.com