Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reflection on cmd structs not to use elem #329

Merged
merged 1 commit into from
May 22, 2023
Merged

fix reflection on cmd structs not to use elem #329

merged 1 commit into from
May 22, 2023

Conversation

chrisfenner
Copy link
Member

In d68ba33, commands were updated to implement Command by value and not by pointer. A little bit of reflection code remained that still called Elem() in certain situations, which panics (since cmd is not a pointer anymore).

@chrisfenner chrisfenner requested review from alexmwu, jkl73 and a team as code owners May 22, 2023 15:33
@chrisfenner chrisfenner merged commit ea5baa1 into google:tpmdirect May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant