Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm2: Implement TPM2_TestParms #352

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

Foxboron
Copy link
Contributor

No description provided.

@Foxboron Foxboron requested review from alexmwu, jkl73 and a team as code owners February 27, 2024 21:23
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response.

Looks good, just needs a typo fix. I made one other optional suggestion if you're up for it.

tpm2/tpm2.go Outdated Show resolved Hide resolved
tpm2/test/test_parms_test.go Outdated Show resolved Hide resolved
@chrisfenner
Copy link
Member

(not sure if the force-push worked as intended; the linter that was updated in #353 now notices the typo)

@Foxboron
Copy link
Contributor Author

(not sure if the force-push worked as intended; the linter that was updated in #353 now notices the typo)

Forgot to pull 🙃

Signed-off-by: Morten Linderud <morten@linderud.pw>
@Foxboron
Copy link
Contributor Author

And it turns out i misspelled the word twice fixing it up. Great job.

@chrisfenner
Copy link
Member

Perfect, looks right now. Thank you for taking me up on the optional testing suggestion! After linters and tests finish up I'll merge.

@chrisfenner chrisfenner merged commit 1fb8444 into google:main Apr 11, 2024
4 checks passed
@chrisfenner
Copy link
Member

And it turns out i misspelled the word twice fixing it up. Great job.

Good to know I'm not the only person who does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants