Fix another import ordering / newline issue

MOE_MIGRATED_REVID=172516439
google · Oct 17, 2017 · 8364f6c · 8364f6c
1 parent 352aac7
commit 8364f6c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/core/src/main/java/com/google/googlejavaformat/java/ImportOrderer.java b/core/src/main/java/com/google/googlejavaformat/java/ImportOrderer.java
@@ -227,10 +227,6 @@ private ImportsAndIndex scanImports(int i) throws FormatterException {
       if (isNewlineToken(i)) {
         trailing.append(tokenAt(i));
         i++;
-      } else if (tokenAt(i).equals("import")) {
-        // continue
-      } else {
-        throw new FormatterException("Extra tokens after import: " + tokenAt(i));
       }
       imports.add(new Import(importedName, trailing.toString(), isStatic));
       // Remember the position just after the import we just saw, before skipping blank lines.

diff --git a/core/src/main/java/com/google/googlejavaformat/java/JavacTokens.java b/core/src/main/java/com/google/googlejavaformat/java/JavacTokens.java
@@ -99,7 +99,7 @@ public static ImmutableList<RawTok> getTokens(
       }
       if (stopTokens.contains(t.kind)) {
         if (t.kind != TokenKind.EOF) {
-          end = t.endPos - 1;
+          end = t.pos;
         }
         break;
       }

diff --git a/core/src/test/java/com/google/googlejavaformat/java/ImportOrdererTest.java b/core/src/test/java/com/google/googlejavaformat/java/ImportOrdererTest.java
@@ -286,7 +286,7 @@ public static Collection<Object[]> parameters() {
           "import com.foo.First;",
         },
         {
-          "!!Extra tokens after import: /* no block comments after imports */",
+          "!!Imports not contiguous (perhaps a comment separates them?)",
         }
       },
       {
@@ -353,7 +353,18 @@ public static Collection<Object[]> parameters() {
           "",
           "class Test {}",
         }
-      }
+      },
+      {
+        {
+          "import com.foo.Second; import com.foo.First; class Test {}",
+        },
+        {
+          "import com.foo.First;", //
+          "import com.foo.Second;",
+          "",
+          "class Test {}",
+        }
+      },
     };
     ImmutableList.Builder<Object[]> builder = ImmutableList.builder();
     for (String[][] inputAndOutput : inputsOutputs) {