-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eclipse plugin for 1.14.0 and newer has version number 1.13.0 #744
Comments
Thanks. This is the first release using a new GitHub actions workflow, and obviously something went wrong there. I think the
I'll try to sort it out. |
Happened again for 1.15.0. |
Forgot to update the version number in eclipse_plugin/pom.xml? google-java-format/eclipse_plugin/pom.xml Line 25 in edf036c
|
Note that as discussed in #835, the wrong version number also makes updating google-java-format tricky because if you just put a new JAR with the same version number in |
Occurred again for 1.16.0. |
Happend again for v1.17.0. The plugin not only keeps the old version but also includes the old version of the google-java-format.jar
|
Happened again for 1.18.0. @cushon Any chance to get this resolved? Upgrading the Eclipse plugin is tedious because of this because Eclipse silently ignores a new JAR if it has the same version number. I suspect that several issues about the Eclipse plugin here would be resolved if the version is fixed. |
I am not currently using Eclipse and it isn't a supported IDE at my day job, which has been contributing the lack of support for Eclipse plugin here. I adjusted the step that is supposed to be updated the versions for the eclipse plugin (https://github.com/google/google-java-format/blob/685a6c9ebd43aab9ef458379de7d3883bfee970f/.github/workflows/release.yml#L34C1-L35), and pushed a draft 1.18.1 release that seems have successfully updated the versions: @PhilippWendler can you let me know if that looks good to you? |
@cushon Thank you very much! I would love to test this, but the last link is not working for me, and https://github.com/google/google-java-format/releases/tag/v1.18.1 doesn't have any JARs. Could you maybe upload it here? |
@PhilippWendler This is the build of the plugin: issue744.zip. (The |
Works perfectly for me! I took my existing Eclipse installation with google-java-format 1.17.0 (which identifies itself as 1.13.0) and just put So from my point of view, this could be released officially. 🎉 Thanks a lot! |
Great, thank you for testing! I have published the release: https://github.com/google/google-java-format/releases/tag/v1.18.1 |
This is consistent with the versions for the other modules. The release process updates the versions and pushes a tagged commit, but the version in the main branch is always 'HEAD-SNAPSHOT'. Follow-up to #744 (comment) PiperOrigin-RevId: 571607356
This is consistent with the versions for the other modules. The release process updates the versions and pushes a tagged commit, but the version in the main branch is always 'HEAD-SNAPSHOT'. Follow-up to #744 (comment) PiperOrigin-RevId: 571607356
This is consistent with the versions for the other modules. The release process updates the versions and pushes a tagged commit, but the version in the main branch is always 'HEAD-SNAPSHOT'. Follow-up to #744 (comment) PiperOrigin-RevId: 571607356
This is consistent with the versions for the other modules. The release process updates the versions and pushes a tagged commit, but the version in the main branch is always 'HEAD-SNAPSHOT'. Follow-up to #744 (comment) PiperOrigin-RevId: 571607356
This is consistent with the versions for the other modules. The release process updates the versions and pushes a tagged commit, but the version in the main branch is always 'HEAD-SNAPSHOT'. Follow-up to #744 (comment) PiperOrigin-RevId: 571607356
The release page on GitHub for 1.14.0 contains a
google-java-format-eclipse-plugin-1.13.0.jar
but not the expectedgoogle-java-format-eclipse-plugin-1.14.0.jar
.The text was updated successfully, but these errors were encountered: