Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of parameters in @-files: add quote-handling for whitespaces in parameters. #931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kfriedberger
Copy link

And abort on recursive include of @-files.

…taining whitespace.

Parameters from @-files are no longer simply split at whitespace,
but now recognize quotes (single or double quotes allowed),
such that parameters can contain whitespace that are kept unmodified.

Each parameter can be written as either a quoted string (single or double quotes are allowed) or a plain unquoted string.
Surrounding quotes are removed from parameters when parsing.
It is possible to have double quotes within a single-quoted string and vice-versa.
Such internal quotes remain untouched when parsing.
For simplicity, we do not handle escaped quotes.
We do not enforce an ending quote in @-files
and simply close the string on end-fo-file.
This might be nicer for the user and does not harm.
@baierd
Copy link

baierd commented Apr 24, 2023

Would it be possible to merge this? I am effected by this issue on my Windows machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants