Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release? #1079

Closed
brandon-arnold opened this issue May 4, 2017 · 22 comments
Closed

Next release? #1079

brandon-arnold opened this issue May 4, 2017 · 22 comments

Comments

@brandon-arnold
Copy link

Hello,

It looks like master is the only branch that builds on all systems for me, and not the most recent 1.8 release around 7 months ago. Is there plan to tag a new release any time soon?

-Brandon

@jhanggj
Copy link

jhanggj commented May 22, 2017

I want to know too.
Thanks

GJ

@4brunu
Copy link

4brunu commented May 22, 2017

I'm also interested in this.
Maybe @BillyDonahue can help.
Thanks

This was referenced May 23, 2017
@SylvainCorlay
Copy link

A 1.8.1 including the fix for mingw support (#721) which was merged right after the last release would be greatly appreciated.

@petko
Copy link

petko commented Jan 17, 2018

Please do something about tagging the new releases.

Right now it's quite confusing for people who are not monitoring closely the development of GTest. I don't know which commits are stable enough for production use. I use 1.8, but it references some TR1 items in the Standard Library and I started getting deprecation warnings in the latest compiler versions..

@SylvainCorlay
Copy link

SylvainCorlay commented Mar 27, 2018

It would be great if core developers could communicate on whether there will be a release or if people should use the master branch in their workflow?

More and more projects out there are relying on forks or arbitrary commits posterior to 1.8, and there is a number of issues open on this repository asking about the next release.

cc @gennadiycivil

@madscientist
Copy link

If GTest decides to go to a "continuous release" model (or really, even if it doesn't) I really would love to see a NEWS file or similar updated in commits that add major new features, important bug fixes, etc. with a description. The Git history doesn't really help: it's a long list of "merge pull request" commit messages, mostly without information about what was actually changed.

I really have no idea what changes I'm getting if I take a cut of the Git repository.

Thanks!

@gennadiycivil
Copy link
Contributor

gennadiycivil commented Mar 28, 2018 via email

@madscientist
Copy link

Thanks for the pointer! I'm afraid I'm a little too slow today to grok it fully. Are you saying that all the changes being made are related to C++11 support and no other changes to GTest are happening, so no NEWS-type file is necessary because there aren't any functional improvements (only rewrites to C++11)?

Or are you saying that the description of how GTest is going to be developed and released going forward is defined by the comment discussing Abseil compatibility policies in the second paragraph?

In either case I still think it would be a good practice to maintain a NEWS or CHANGES file. It may currently have only one entry ("Convert GTest to C++11"), but it will give a good place to add information in the future. If there are no more releases, there won't be release notes or whatever. It's good if the documentation is up to date and we can always get the latest code (due to compatibility guarantees), but scanning the documentation to see what improvements might have been made since the last time we used GTest, that we can take advantage of, is not really feasible.

There is already a CHANGES file available, but it doesn't seem to have been updated since 1.7.0.

Also it would probably be helpful to users to update the front-facing README.md file with information on the release model using Abseil now, instead of having it stashed in a Git issue.

Thanks!

@gennadiycivil
Copy link
Contributor

@madscientist Just a clarification

  • There is on-going merging work that will result in 1.8.1 being produced. The 1.8.1 will be the last release that works with pre-C++11 compilers. The 1.8.1 will not accept any requests for any new features and any bugfix requests will only be accepted if proven "critical"

  • After 1.8.1 is ready , the work will start to remove C++98 support / cleanup code in the master branch At some point when this work is completed there will be a 1.9.0 tagged release and after that googletest will follow Abseil compatibility policies.

The question about NEWS file and CHANGES file is orthogonal to this process.

HTH
G

@SylvainCorlay
Copy link

Many thanks @gennadiycivil for the update, and more generally for all the work on maintaining and pushing googletest forward.

@henryiii
Copy link
Contributor

henryiii commented Apr 4, 2018

That's great, @gennadiycivil! Will the current changes in master go into 1.8.1 or 1.9.0?

@gennadiycivil
Copy link
Contributor

gennadiycivil commented Apr 4, 2018

@henryiii , the plan is for the current changes in master to eventually culminate in 1.8.1 . After that master becomes subject to general cleanup and removal of old C++98 baggage which will result in 1.9.0.

@henryiii
Copy link
Contributor

henryiii commented Apr 4, 2018

Thanks for the clarification, that would be great!

(PS: Not that it matters, but why not call that 1.9 and then make the C++11 only support version 2.0? I'm sure this discussion was held at some point.)

@gennadiycivil
Copy link
Contributor

gennadiycivil commented Apr 4, 2018 via email

@gennadiycivil
Copy link
Contributor

Another update, time-wise. No promises but we anticipate making 1.8.1 release in the coming months.
Hope this helps.

@zz-pony
Copy link

zz-pony commented Jun 29, 2018

Thanks for working on a new release. I can't help asking, when will 1.8.1 become ready?

@m-tmatma
Copy link
Contributor

Please don't release without fixing #1595(#1606).

@SylvainCorlay
Copy link

Is there any blocker for tagging 1.8.1 ?

@gennadiycivil
Copy link
Contributor

Should be "really soon now", cant promise exact date.

@gennadiycivil
Copy link
Contributor

https://github.com/google/googletest/releases/tag/release-1.8.1

@bilelzouari
Copy link

will there be a release for GTEST_SKIP() or not yet? thanks

@gennadiycivil
Copy link
Contributor

gennadiycivil commented Jul 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests