Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Googletest commit in quickstart-bazel.md fails with Bazel 6. #4096

Closed
oliverlee opened this issue Dec 20, 2022 · 0 comments
Closed

[Bug]: Googletest commit in quickstart-bazel.md fails with Bazel 6. #4096

oliverlee opened this issue Dec 20, 2022 · 0 comments

Comments

@oliverlee
Copy link

Describe the issue

The current quickstart guide for building with Bazel uses commit
6092810

With Bazel 6, there is a build failure with the following message:

Constraints from @bazel_tools//platforms have been removed. Please use
constraints from @platforms repository embedded in Bazel, or preferably
declare dependency on https://github.com/bazelbuild/platforms. See
https://github.com/bazelbuild/bazel/issues/8622 for details.

This is resolved with a more recent commit (e.g. HEAD).

Steps to reproduce the problem

Copy the directions in https://github.com/google/googletest/blob/main/docs/quickstart-bazel.md

❯ USE_BAZEL_VERSION=6.0.0 bazelisk build //...

What version of GoogleTest are you using?

6092810

What operating system and version are you using?

ubuntu 20.04

What compiler and version are you using?

gcc 9

What build system are you using?

Bazel 6.0.0

Additional context

No response
dneto0 added a commit to dneto0/googletest that referenced this issue Dec 21, 2022
@dneto0
Bazel quickstart: use a more recent commit of googletest
f050d63 
Use a more recent commit of googletest that uses OS constraints
from @platforms//os:* instead of from @build_tools//platforms:*

See bazelbuild/bazel#8622

Necessary to fix google#4096

Also need the fix for google#4098
@dneto0 dneto0 mentioned this issue Dec 21, 2022
Closed
@DavidKorczynski DavidKorczynski mentioned this issue Dec 21, 2022
Closed
gaspardpetit pushed a commit to eidosmontreal/googletest that referenced this issue Feb 24, 2023
Use a more recent commit of googletest that uses OS constraints from
b914642 
@platforms//os:* instead of from @build_tools//platforms:*

See bazelbuild/bazel#8622

Necessary to fix google#4096

Also need the fix for google#4098

PiperOrigin-RevId: 497182073
Change-Id: Ifd568b088d2f779755dd20264edfd5dad12ca9cc
kunitoki pushed a commit to kunitoki/googletest that referenced this issue Nov 4, 2023
@kunitoki
Use a more recent commit of googletest that uses OS constraints from
bfd4df4 
@platforms//os:* instead of from @build_tools//platforms:*

See bazelbuild/bazel#8622

Necessary to fix google#4096

Also need the fix for google#4098

PiperOrigin-RevId: 497182073
Change-Id: Ifd568b088d2f779755dd20264edfd5dad12ca9cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bazel quickstart: use a more recent commit of googletest dneto0/googletest
1 participant
@oliverlee