Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: --gtest_stream_result_to support on macOS #4214

Closed
davidben opened this issue Apr 11, 2023 · 0 comments
Closed

[FR]: --gtest_stream_result_to support on macOS #4214

davidben opened this issue Apr 11, 2023 · 0 comments

Comments

@davidben
Copy link
Contributor

davidben commented Apr 11, 2023

Does the feature exist in the most recent commit?

No

Why do we need this feature?

We're evaluating ways to report GTest test results more robustly in BoringSSL. The JSON format is an option but it doesn't work when the test binary crashes.

--gtest_stream_result_to would avoid that (edit: though it seems to not include other output, so maybe it's not what we want?), but there's no Windows and macOS support. Looks like someone's got Windows support in #3989. Missing macOS support seems to just be a mistake in GTest. (See below)

Describe the proposal.

There doesn't seem to be any real reason this feature doesn't work on macOS. GTEST_CAN_STREAM_RESULTS_ isn't defined for GTEST_OS_MAC, but if I fix that, it works just fine. It's just based on sockets. This seems to just have been an oversight in GTest.
https://github.com/google/googletest/blob/main/googletest/include/gtest/internal/gtest-port.h#L692-L700

Is the feature specific to an operating system, compiler, or build system version?

macOS

kunitoki pushed a commit to kunitoki/googletest that referenced this issue Nov 4, 2023
This seems to just have been an oversight. POSIX socket APIs work just
fine on macOS.

Fixes google#4214.

PiperOrigin-RevId: 523398386
Change-Id: I9d56cd9c6933318c1f0b0024f7fef44122fd0c83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant