Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag: release-1.13.0 #4235

Closed
hellow554 opened this issue May 9, 2023 · 4 comments
Closed

Missing tag: release-1.13.0 #4235

hellow554 opened this issue May 9, 2023 · 4 comments
Assignees

Comments

@hellow554
Copy link

hellow554 commented May 9, 2023

Describe the issue

When I want to check this library out via the git tag, it's done via the version info provided by a script, which searches for the tag release-1.13.0, but it doesn't exist.
Seems to be an oversight, please add it :)

Steps to reproduce the problem

git clone https://github.com/google/googletest
git checkout release-1.13.0
@ro4i7
Copy link

ro4i7 commented May 12, 2023

Hello @hellow554 @derekmauro please check #4247

@hellow554
Copy link
Author

I'm not sure what do you want to tell me with that PR.

It has nothing to do with mine?

@dinord dinord self-assigned this May 15, 2023
@dinord
Copy link
Collaborator

dinord commented May 16, 2023

We used to tag them with release-${major}.${minor}.${patch}, but decided to use tags that match release names.

@hellow554
Copy link
Author

Thanks for mentioning that in the Readme.

Is this something that is done from now on?
E.g. there's a version 1.12.1, but not a v1.12.1 tag for it, but instead a release-1.12.1 tag.

That's a little bit weird :/

kunitoki pushed a commit to kunitoki/googletest that referenced this issue Nov 4, 2023
Fixes google#4235

PiperOrigin-RevId: 532446854
Change-Id: If7e1dade02a80d9a30813c136bba3f20c796f0fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants