Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Streaming results format to stdout #4665

Open
davidmatson opened this issue Nov 20, 2024 · 9 comments
Open

[FR]: Streaming results format to stdout #4665

davidmatson opened this issue Nov 20, 2024 · 9 comments

Comments

@davidmatson
Copy link
Contributor

davidmatson commented Nov 20, 2024

Does the feature exist in the most recent commit?

No

Why do we need this feature?

Currently, we have per-OS code for stream_result_to, and Windows support is not yet available.

Describe the proposal.

Provide a switch to have stdout report progress in the same format used by stream_result_to rather than the human-readable format.

Perhaps:
--gtest_machine_results
or
--gtest_stream_result_to=stdout

Is the feature specific to an operating system, compiler, or build system version?

No

@RedMarcher
Copy link

RedMarcher commented Nov 21, 2024

Hello, I'm new to this particular project. Would you mind telling me which file the current implementation for stream_result_to is located at? You mentioned that it was different for each OS, so is the feature implementation currently spread out among multiple different files?

@RedMarcher
Copy link

Looking over your comment more closely, do you just want a feature where whatever is currently spit out of stream_result_to is also available to stdout?

@davidmatson
Copy link
Contributor Author

Looking over your comment more closely, do you just want a feature where whatever is currently spit out of stream_result_to is also available to stdout?

yes (and also not having the pretty-print format written stdout)

@RedMarcher
Copy link

Looking over your comment more closely, do you just want a feature where whatever is currently spit out of stream_result_to is also available to stdout?

yes (and also not having the pretty-print format written stdout)

So basically I should add a new flag using one of the names you proposed to activate this feature?

@davidmatson
Copy link
Contributor Author

So basically I should add a new flag using one of the names you proposed to activate this feature?

This is a feature request to add a new flag that would control this behavior, yes.

@davidmatson
Copy link
Contributor Author

@derekmauro - thoughts on this proposal? We'd be interested in working on a draft implementation, if there's agreement that this would be a good idea.

@RedMarcher
Copy link

@derekmauro - thoughts on this proposal? We'd be interested in working on a draft implementation, if there's agreement that this would be a good idea.

I already have a sort of merge request. Unfortunately no one has looked at it yet. This project is a little bit quiet. If you could take a look and give me your thoughts, I'd appreciate it.

#4668

@davidmatson
Copy link
Contributor Author

@RedMarcher - I think we'll be best off if we can get someone from the GoogleTest team to consider the feature request before we get too deep into implementation details. Sometimes it can take a while for those folks to review, and I'm not sure of any way to accelerate that process.

@RedMarcher
Copy link

RedMarcher commented Dec 7, 2024

@RedMarcher - I think we'll be best off if we can get someone from the GoogleTest team to consider the feature request before we get too deep into implementation details. Sometimes it can take a while for those folks to review, and I'm not sure of any way to accelerate that process.

Alright, I'll set my pull request to draft and wait for further updates. At least all the boiler plate is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants