New feature implementation: Streaming results format to stdout #4665 #4668
+80
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea what caused this. This isn't supposed to be changed
FInally removed this unwanted change
|
I noticed the use of lots of #if compiler commands. Is this applicable to the feature? If the flag is set to true, should I just have a function which prints results in the same format as from stream_result_to to the console using cout and stream operators? |
|
After reviewing the rest of the code some more, I realize stream_result_to doesn't actually create a function, rather it adds a new listener to a preexisting list. I'm wondering if printing to the terminal should follow the same behavior, or if it should be more "direct" somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't actually implemented the feature yet, for now I've just added the flags necessary for it.
I would like to ask for more clarifications about how result streaming is currently handled before adding in new feature code.