work around GCC 6~11 ADL bug #3993
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| // ADL (possibly involving implicit conversions). | ||
| // (Use SFINAE via return type, because it seems GCC < 12 doesn't handle name | ||
| // lookup properly when we do it in the template parameter list.) | ||
| static decltype(std::declval<std::ostream&>() << std::declval<const T&>(), |
There was a problem hiding this comment.
Nitpick:
Lets write this with trailing retrun type so we have access to the variables and can avoid std::declval:
static auto PrintValue(const T& value, ::std::ostream* os) -> decltype((void)(*os << value)) { ... }
|
Generally looks good. Please sign the CLA, and we'll get this merged. |
|
The CLA should be signed, but somehow it still doesn't work. The issue is being discussed here: google/closure-compiler#3988 |
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51577 ADL seems to work properly when we do the SFINAE check via the return type, but not when using a dummy template parameter fix google#3992
pgroke-dt
force-pushed
the
work-around-GCC-11-ADL-bug
branch
from
7a898d3
to
096014a
Compare
|
@asoffer Sorry for taking so long, but the CLA check is finally green now. |
|
@asoffer Hi. I made the changes you requested and the CLA check is green. Is there anything blocking us from moving forward with this? |
|
@asoffer @derekmauro I'd really like to proceed with this. Please let me know if there's something I need to do before this can be merged. |
|
@asoffer @derekmauro @dinord could someone of you please look into this? This bug is what is keeping me from moving to following HEAD of googletest in my projects as they fail to compile 👀 |
|
is there any news on this one? |
|
Unfortunately not and I have the feeling that my pings to @asoffer @derekmauro and @dinord didn't get through 🤷 |
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51577
ADL seems to work properly when we do the SFINAE check via the return type, but not when using a dummy template parameter
fix #3992