Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings with nvc++ as the compiler #4103

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

gonzalobg
Copy link
Contributor

Closes #3849.

I've submitted a CLA.

@gonzalobg
Copy link
Contributor Author

@ProKashif could you approve the workflow so that tests can pass and we can merge this? Thanks!

@derekmauro derekmauro self-assigned this Jan 9, 2023
@gonzalobg
Copy link
Contributor Author

@ProKashif @derekmauro the CI error looks unrelated to this PR. Do you know what caused this? (and if its unrelated, could we run CI again?). Thanks!

@gonzalobg
Copy link
Contributor Author

@thughes maybe?

@thughes
Copy link
Member

thughes commented Feb 15, 2023

You could try rebasing on the latest main, which has fixes for the Windows CI that have landed since you opened the PR; pushing that may re-trigger the CI checks.

@gonzalobg
Copy link
Contributor Author

@derekmauro ping

@gonzalobg
Copy link
Contributor Author

Made a small change to trigger CI again, hopefully it won't spuriously fail again.
Due to the change, @ProKashif this needs to be approved, again.

@gonzalobg
Copy link
Contributor Author

@thughes ping

@copybara-service copybara-service bot merged commit ca0d46e into google:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings with nvc++ as the compiler
5 participants