[gmock] Rename struct Result to avoid shadowing #4221
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@ankit-gautam23 I agree, so maybe let's change that struct name to something to one of this: NonMoveableType, NonMoveableStruct, NonMoveableData, NonMoveableTestData or just NonMoveable. Or perhaps you have diffrent proposition? |
|
@TurboGawron Its truly okay. I will update this and raise the PR. Will add you as a reviewer. Thanks |
| struct Result { | ||
| explicit Result(int x_in) : x(x_in) {} | ||
| Result(Result&&) = delete; | ||
| struct result { |
There was a problem hiding this comment.
Can we name it NonMoveableStruct?
pgawro
force-pushed
the
main
branch
2 times, most recently
from
7638dba
to
d40fcb4
Compare
Struct Result shadows global definition of class Result in gmock-spec-builders_test.cc inside ExpectCallTest.NonMoveableType test