cmake: Raise min to 3.6 #4288
cmake: Raise min to 3.6 #4288
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| if (POLICY CMP0048) | ||
| cmake_policy(SET CMP0048 NEW) | ||
| endif (POLICY CMP0048) |
There was a problem hiding this comment.
Manually setting this policy is only necessary if the minimum is 2.X
It's safe to remove this code since the min is 3.6
https://cmake.org/cmake/help/latest/policy/CMP0048.html#policy:CMP0048
From the CMake 3.27 release notes: Compatibility with versions of CMake older than 3.5 is now deprecated and will be removed from a future version. Calls to cmake_minimum_required() or cmake_policy() that set the policy version to an older value now issue a deprecation diagnostic. This PR also removes manually setting policy CMP0048. This is redundant since the CMake min is already 3.X
|
We used your change to bump the min to 3.13 because that's the oldest officially supported version of CMake, as per https://opensource.google/documentation/policies/cplusplus-support. |
|
Cool beans 👍🏾 |
From the CMake 3.27 release notes:
Compatibility with versions of CMake older than 3.5 is now deprecated and will be removed from a future version. Calls to cmake_minimum_required() or cmake_policy() that set the policy version to an older value now issue a deprecation diagnostic.
This PR also removes manually setting policy CMP0048. This is redundant since the CMake min is already 3.X