Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move camera position to geometry when restoring draw area tasks #2868

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

shobhitagarwal1612
Copy link
Member

Fixes #2847

@gino-m PTAL?

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.32%. Comparing base (59ae309) to head (3d6ac2f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ollection/tasks/polygon/DrawAreaTaskMapFragment.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2868      +/-   ##
============================================
- Coverage     61.37%   61.32%   -0.05%     
  Complexity     1176     1176              
============================================
  Files           266      266              
  Lines          6325     6330       +5     
  Branches        903      904       +1     
============================================
  Hits           3882     3882              
- Misses         1916     1921       +5     
  Partials        527      527              
Files with missing lines Coverage Δ
...ollection/tasks/polygon/DrawAreaTaskMapFragment.kt 20.83% <0.00%> (-5.49%) ⬇️

@gino-m gino-m merged commit 981478b into master Nov 25, 2024
4 checks passed
@gino-m gino-m deleted the ashobhit/2847/viewport branch November 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Geometry data collection tasks] Geometry sometimes not visible on map when returning to task
3 participants