Error Handling for urlConnection

[anandwana001]

Fixes #2683

@shobhitagarwal1612 PTAL?

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.

Project coverage is 62.14%. Comparing base (1687320) to head (9530810).

Files with missing lines	Patch %	Lines
...lineareas/selector/OfflineAreaSelectorViewModel.kt	6.25%	15 Missing ⚠️
...flineareas/selector/OfflineAreaSelectorFragment.kt	50.00%	1 Missing and 4 partials ⚠️
...android/ground/repository/OfflineAreaRepository.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2902      +/-   ##
============================================
- Coverage     62.25%   62.14%   -0.11%     
- Complexity     1202     1203       +1     
============================================
  Files           265      265              
  Lines          6416     6433      +17     
  Branches        890      894       +4     
============================================
+ Hits           3994     3998       +4     
- Misses         1866     1876      +10     
- Partials        556      559       +3     

Files with missing lines	Coverage Δ
...le/android/ground/ui/map/gms/mog/UrlInputStream.kt	0.00% <ø> (ø)
...android/ground/repository/OfflineAreaRepository.kt	49.18% <0.00%> (ø)
...flineareas/selector/OfflineAreaSelectorFragment.kt	44.64% <50.00%> (-1.20%)	⬇️
...lineareas/selector/OfflineAreaSelectorViewModel.kt	24.41% <6.25%> (-1.56%)	⬇️

[gino-m]

We should handle the error upstream where it can actually be addressed:

ground-android/ground/src/main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt

Lines 100 to 113 in 9ef90ad

	viewModelScope.launch(ioDispatcher) {
	offlineAreaRepository.downloadTiles(viewport!!).collect { (bytesDownloaded, totalBytes) ->
	val progressValue =
	if (totalBytes > 0) {
	(bytesDownloaded.toFloat() / totalBytes.toFloat()).coerceIn(0f, 1f)
	} else {
	0f
	}
	downloadProgress.postValue(progressValue)
	}
	isDownloadProgressVisible.postValue(false)
	_navigate.emit(UiState.OfflineAreaBackToHomeScreen)
	}
	}

You would add .catch{} before collect to handle the failure (show a toast and close the dialog).

[gino-m]

Thanks! A few requests, LG

[gino-m]

Can we add tests for this logic?

[gino-m]

Can you also add tests for this logic as well?