Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds functionality to autocreate signed URLs for large file upload #1116

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

daschwanden
Copy link
Contributor

This PR proposes an approach to autocreate signed URLs for large file upload with the Collect Large File flow.

  • The approach taken is to autocreate the signed URLs in case the user (either via the UI or the API) creates a Collect Large File flow without submitting a signed URL.
  • In case a Service Account (Server.signed_url_service_account_email) and a GCS Bucket (Server.signed_url_gcs_bucket_name) are configured and GRR is running on Google Kubernetes Engine (GKE) with Workload Identity Federation configured then the autocreation of the signed URL will succeed (see GRR documentation for more detail: https://grr-doc.readthedocs.io/en/latest/investigating-with-grr/collect-large-file.html).
  • In case the above assumptions do not hold true then the Collect Large File flow will behave as it did before this functionality was introduced.
  • Of course, the user is still free to create their own signed URL and run the Collect Large File flow as they did before this functionality was introduced.

@mbushkov mbushkov merged commit 08b2075 into google:master Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants