-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unused LinkedHashTreeMap #1992
Delete unused LinkedHashTreeMap #1992
Conversation
I'm concerned that this a public class. Even though it's in a package with |
Marking it deprecated for now would also be alright for me, but I think it should be removed eventually. There is no point in including a class (and maintaining tests for it) which is not used by Gson at all; if we ever need it again we can revive it from the Git history. It appears that class was originally introduced to protect against DoS attacks (see this StackOverflow comment), but Java's |
Users use classes from internal at their own risk, we should merge it. |
OK, given that the need for this class is obviated by DoS protection in the JDK and given that the class is |
Class seems to be unused since commit f29d5bc. Gson currently only uses LinkedTreeMap.
4efb3dd
to
42f2076
Compare
2.8.9 has now been released, so as agreed I am merging this. |
Class seems to be unused since commit f29d5bc. Gson currently only uses LinkedTreeMap.
The is an internal class never intended for use outside of GSON. It was removed in google/gson#1992 (version 2.9.0) and its use in this project prevents the GSON version from being bumped. The standard is a perfect drop-in replacement as it also preserves insertion order.
LinkedHashTreeMap is an internal class never intended for use outside of GSON. It was removed in google/gson#1992 (version 2.9.0) and its use in this project prevents the GSON version from being bumped. The standard LinkedHashMap is a perfect drop-in replacement as it also preserves insertion order.
Class seems to be unused since commit f29d5bc.
Gson currently only uses LinkedTreeMap.