14 control flow characters not in 0x0000 0x001f #2329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strict mode is used
…specific escape sequence representing in strict mode
# Conflicts: # gson/src/test/java/com/google/gson/stream/JsonReaderTest.java
… and GsonBuilder
…s in Strict Mode
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
It seems that your PR is very similar to #2323. What's the difference? Note: The build fails because there is a formatting error in the Javadoc. I will leave a review 🙂 |
| @@ -1198,7 +1198,7 @@ public <T> T fromJson(JsonReader reader, Type typeOfT) throws JsonIOException, J | |||
| * <p>Unlike the other {@code fromJson} methods, no exception is thrown if the JSON data has | |||
| * multiple top-level JSON elements, or if there is trailing data. | |||
| * | |||
| * <p>The JSON data is parsed in {@linkplain JsonReader#setLenient(boolean) lenient mode}, | |||
| * <p>//todo: update javadoc The JSON data is parsed in {@ linkplain JsonReader#setLenient(boolean) lenient mode}, | |||
There was a problem hiding this comment.
The build fails because there is a whitespace between @ and linkplain.
Should be: @linkplain ...
|
Sorry, was mistake |
|
Accidentally opened this on non-fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.