Specify Error Prone JVM args with .mvn/jvm.config
#2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows avoiding fork mode for compilation, which: - might slightly reduce compilation time - guarantees that all compiler diagnostics are properly reported
Marcono1234
commented
Mar 6, 2023
| <rules> | ||
| <requireMavenVersion> | ||
| <!-- Usage of `.mvn/jvm.config` for Error Prone requires at least Maven 3.3.1 --> | ||
| <version>[3.3.1,)</version> |
There was a problem hiding this comment.
Possibly some plugins used during build already require a newer version, but version 3.3.1 (released in 2015) added support for .mvn/jvm.config, so it is definitely the lower bound.
Merged
|
Thanks again! |
eamonnmcmanus
pushed a commit
that referenced
this pull request
May 31, 2023
* Specify Error Prone JVM args with `.mvn/jvm.config` This allows avoiding fork mode for compilation, which: - might slightly reduce compilation time - guarantees that all compiler diagnostics are properly reported * Combine enforcer executions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Specify JVM arguments needed for Error Prone using the
.mvn/jvm.configfile.Description
This allows avoiding fork mode for compilation, which:
See also #2320 (comment) and comments above.
Checklist
null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors