Only create one BoundField instance per field in ReflectiveTypeAdapterFactory
#2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…rFactory Instead of creating a BoundField for every possible name of a field (for SerializedName usage) and then storing for that BoundField whether it is serialized or deserialized, instead only create one BoundField and then have a separate Map<String, BoundField> for deserialized fields, and a separate List<BoundField> for serialized fields.
Marcono1234
force-pushed
the
marcono1234/refactor-BoundField-creation
branch
from
9819be8 to
8a5d6ea
Compare
eamonnmcmanus
requested changes
Sep 29, 2023
There was a problem hiding this comment.
This looks great. I ran it past Google's tests and had no problems. (Except one place where people were accessing the internals of ReflectiveTypeAdapterFactory via reflection. I'll update that at the same time as I import these changes.)
Just one trivial request.
gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java
Outdated
Show resolved
Hide resolved
eamonnmcmanus
approved these changes
Sep 30, 2023
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
…pterFactory` (google#2440) * Only create one BoundField instance per field in ReflectiveTypeAdapterFactory Instead of creating a BoundField for every possible name of a field (for SerializedName usage) and then storing for that BoundField whether it is serialized or deserialized, instead only create one BoundField and then have a separate Map<String, BoundField> for deserialized fields, and a separate List<BoundField> for serialized fields. * Fix indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #2438
Description
Instead of creating a
BoundFieldfor every possible name of a field (for@SerializedNameusage) and then storing for thatBoundFieldwhether it is serialized or deserialized, instead only create oneBoundFieldand then have a separateMap<String, BoundField>for deserialized fields, and a separateList<BoundField>for serialized fields.This shouldn't cause any changes visible to the user.
Not sure if this implementation is clean enough; feedback is appreciated!
Checklist
null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors