-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump com.google.errorprone:error_prone_core from 2.21.1 to 2.22.0 #2492
Bump com.google.errorprone:error_prone_core from 2.21.1 to 2.22.0 #2492
Conversation
Éamonn, in case you edit this PR anyways to fix the build issue; Error Prone version 2.22.0 fixed a false positive for record components (google/error-prone#2713). Could you please remove the following annotations which were needed as workaround? It looks like Error Prone still succeeds afterwards. Line 30 in e93fda9
gson/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java Lines 259 to 260 in e93fda9
gson/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java Lines 413 to 416 in e93fda9
Or please let me know if I should make those changes. |
@dependabot rebase |
Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.21.1 to 2.22.0. - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.21.1...v2.22.0) --- updated-dependencies: - dependency-name: com.google.errorprone:error_prone_core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
0579468
to
6a61e20
Compare
I think it's cleanest to have three PRs:
I've just done 1 and 2.
If you don't mind, I would appreciate it. |
Personally I think it would have also been quite clean to combine this with the PR updating the Error Prone version, since these changes are directly related to it. Though like this it is fine for me as well.
Have created #2497 |
Bumps com.google.errorprone:error_prone_core from 2.21.1 to 2.22.0.
Release notes
Sourced from com.google.errorprone:error_prone_core's releases.
Commits
7114c31
Release Error Prone 2.22.0c94d74d
Update release.yml - temporarily disable sonatype deployments080411e
Added exempting variable annotations737dec0
Remove DiffNotApplicableExceptionf3a2bf8
Update ci.yml for JDK 21 release1d2bc93
IntroduceErrorProneFlags.get{Set,List}OrEmpty
, because basically every cal...1bec842
Fix a crash in UnnecessaryAsyncd2ee28e
Fix a crash in TimeUnitConversionCheckerac424d0
Tighten the return types in Fix.58e5bb8
Update and wordsmith the@CompileTimeConstant
documentation to reflect chan...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)